fix(paths): gracefully handle nulls for local cleaning filters#26085
fix(paths): gracefully handle nulls for local cleaning filters#26085thmsobrmlr merged 3 commits intomasterfrom
Conversation
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
anirudhpillai
left a comment
anirudhpillai
left a comment
There was a problem hiding this comment.
Looks good.
Regarding Python doesn't distinguish between null and undefined what's the exact case we need to distinguish between null and undefined on the backend? (just checking if the field was ever set?)
So the thing is that we validate the queries backend side, where Meaning we can't change the validation on the backend, but we can change the definitions in |
2 participants
Problem
Duplicating an insight leads to
nulls in the query. For the local path cleaning filters this resulted in a crash for a customer.Changes
Gracefully handles
nullvalues for the local path cleaning filter.Follow-ups
Look into wether duplicating an insight creates these-> could not reproducenulls, and if so - fix thatnullandundefined, meaning we have no protection from "faulty" queries like this in our backend side validation. Likely we should addnulls to the wholeschema.tstypes where we have an optional value.How did you test this code?
Used the query from the customer locally to verify the issue and fix.