fix(paths): gracefully handle nulls for local cleaning filters #26085
+27
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Duplicating an insight leads to
nulls in the query. For the local path cleaning filters this resulted in a crash for a customer.Changes
Gracefully handles
nullvalues for the local path cleaning filter.Follow-ups
Look into wether duplicating an insight creates these-> could not reproducenulls, and if so - fix thatnullandundefined, meaning we have no protection from "faulty" queries like this in our backend side validation. Likely we should addnulls to the wholeschema.tstypes where we have an optional value.How did you test this code?
Used the query from the customer locally to verify the issue and fix.